Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: src/crankshaft/arm64/lithium-codegen-arm64.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h" 5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 masm()->CheckVeneerPool(true, true); 810 masm()->CheckVeneerPool(true, true);
811 safepoints_.Emit(masm(), GetTotalFrameSlotCount()); 811 safepoints_.Emit(masm(), GetTotalFrameSlotCount());
812 return !is_aborted(); 812 return !is_aborted();
813 } 813 }
814 814
815 815
816 void LCodeGen::FinishCode(Handle<Code> code) { 816 void LCodeGen::FinishCode(Handle<Code> code) {
817 DCHECK(is_done()); 817 DCHECK(is_done());
818 code->set_stack_slots(GetTotalFrameSlotCount()); 818 code->set_stack_slots(GetTotalFrameSlotCount());
819 code->set_safepoint_table_offset(safepoints_.GetCodeOffset()); 819 code->set_safepoint_table_offset(safepoints_.GetCodeOffset());
820 Handle<ByteArray> source_positions =
821 source_position_table_builder_.ToSourcePositionTable();
822 code->set_source_position_table(*source_positions);
823 PopulateDeoptimizationData(code); 820 PopulateDeoptimizationData(code);
824 } 821 }
825 822
826 void LCodeGen::DeoptimizeBranch( 823 void LCodeGen::DeoptimizeBranch(
827 LInstruction* instr, DeoptimizeReason deopt_reason, BranchType branch_type, 824 LInstruction* instr, DeoptimizeReason deopt_reason, BranchType branch_type,
828 Register reg, int bit, Deoptimizer::BailoutType* override_bailout_type) { 825 Register reg, int bit, Deoptimizer::BailoutType* override_bailout_type) {
829 LEnvironment* environment = instr->environment(); 826 LEnvironment* environment = instr->environment();
830 RegisterEnvironmentForDeoptimization(environment, Safepoint::kNoLazyDeopt); 827 RegisterEnvironmentForDeoptimization(environment, Safepoint::kNoLazyDeopt);
831 Deoptimizer::BailoutType bailout_type = 828 Deoptimizer::BailoutType bailout_type =
832 info()->IsStub() ? Deoptimizer::LAZY : Deoptimizer::EAGER; 829 info()->IsStub() ? Deoptimizer::LAZY : Deoptimizer::EAGER;
(...skipping 4864 matching lines...) Expand 10 before | Expand all | Expand 10 after
5697 // Index is equal to negated out of object property index plus 1. 5694 // Index is equal to negated out of object property index plus 1.
5698 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5695 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5699 __ Ldr(result, FieldMemOperand(result, 5696 __ Ldr(result, FieldMemOperand(result,
5700 FixedArray::kHeaderSize - kPointerSize)); 5697 FixedArray::kHeaderSize - kPointerSize));
5701 __ Bind(deferred->exit()); 5698 __ Bind(deferred->exit());
5702 __ Bind(&done); 5699 __ Bind(&done);
5703 } 5700 }
5704 5701
5705 } // namespace internal 5702 } // namespace internal
5706 } // namespace v8 5703 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698