Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 2248643003: Simplify time tracking in SMILTimeContainer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: begin() -> start(); touch-up comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2014 Google, Inc. 5 * Copyright (C) 2014 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 if (rootParent->document().isXMLDocument()) 505 if (rootParent->document().isXMLDocument())
506 UseCounter::count(document(), UseCounter::SVGSVGElementInXMLDocument ); 506 UseCounter::count(document(), UseCounter::SVGSVGElementInXMLDocument );
507 507
508 if (RuntimeEnabledFeatures::smilEnabled()) { 508 if (RuntimeEnabledFeatures::smilEnabled()) {
509 document().accessSVGExtensions().addTimeContainer(this); 509 document().accessSVGExtensions().addTimeContainer(this);
510 510
511 // Animations are started at the end of document parsing and after f iring the load event, 511 // Animations are started at the end of document parsing and after f iring the load event,
512 // but if we miss that train (deferred programmatic element insertio n for example) we need 512 // but if we miss that train (deferred programmatic element insertio n for example) we need
513 // to initialize the time container here. 513 // to initialize the time container here.
514 if (!document().parsing() && !document().processingLoadEvent() && do cument().loadEventFinished() && !timeContainer()->isStarted()) 514 if (!document().parsing() && !document().processingLoadEvent() && do cument().loadEventFinished() && !timeContainer()->isStarted())
515 timeContainer()->begin(); 515 timeContainer()->start();
516 } 516 }
517 } 517 }
518 return SVGGraphicsElement::insertedInto(rootParent); 518 return SVGGraphicsElement::insertedInto(rootParent);
519 } 519 }
520 520
521 void SVGSVGElement::removedFrom(ContainerNode* rootParent) 521 void SVGSVGElement::removedFrom(ContainerNode* rootParent)
522 { 522 {
523 if (rootParent->isConnected()) { 523 if (rootParent->isConnected()) {
524 SVGDocumentExtensions& svgExtensions = document().accessSVGExtensions(); 524 SVGDocumentExtensions& svgExtensions = document().accessSVGExtensions();
525 svgExtensions.removeTimeContainer(this); 525 svgExtensions.removeTimeContainer(this);
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 visitor->trace(m_width); 731 visitor->trace(m_width);
732 visitor->trace(m_height); 732 visitor->trace(m_height);
733 visitor->trace(m_translation); 733 visitor->trace(m_translation);
734 visitor->trace(m_timeContainer); 734 visitor->trace(m_timeContainer);
735 visitor->trace(m_viewSpec); 735 visitor->trace(m_viewSpec);
736 SVGGraphicsElement::trace(visitor); 736 SVGGraphicsElement::trace(visitor);
737 SVGFitToViewBox::trace(visitor); 737 SVGFitToViewBox::trace(visitor);
738 } 738 }
739 739
740 } // namespace blink 740 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698