Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

Issue 2248643003: Simplify time tracking in SMILTimeContainer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: begin() -> start(); touch-up comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Rob Buis <buis@kde.org> 4 * Copyright (C) 2007 Rob Buis <buis@kde.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 { 116 {
117 // FIXME: Eventually every "Time Container" will need a way to latch on to s ome global timer 117 // FIXME: Eventually every "Time Container" will need a way to latch on to s ome global timer
118 // starting animations for a document will do this "latching" 118 // starting animations for a document will do this "latching"
119 // FIXME: We hold a ref pointers to prevent a shadow tree from getting remov ed out from underneath us. 119 // FIXME: We hold a ref pointers to prevent a shadow tree from getting remov ed out from underneath us.
120 // In the future we should refactor the use-element to avoid this. See https ://webkit.org/b/53704 120 // In the future we should refactor the use-element to avoid this. See https ://webkit.org/b/53704
121 HeapVector<Member<SVGSVGElement>> timeContainers; 121 HeapVector<Member<SVGSVGElement>> timeContainers;
122 copyToVector(m_timeContainers, timeContainers); 122 copyToVector(m_timeContainers, timeContainers);
123 for (const auto& container : timeContainers) { 123 for (const auto& container : timeContainers) {
124 SMILTimeContainer* timeContainer = container->timeContainer(); 124 SMILTimeContainer* timeContainer = container->timeContainer();
125 if (!timeContainer->isStarted()) 125 if (!timeContainer->isStarted())
126 timeContainer->begin(); 126 timeContainer->start();
127 } 127 }
128 } 128 }
129 129
130 void SVGDocumentExtensions::pauseAnimations() 130 void SVGDocumentExtensions::pauseAnimations()
131 { 131 {
132 for (SVGSVGElement* element : m_timeContainers) 132 for (SVGSVGElement* element : m_timeContainers)
133 element->pauseAnimations(); 133 element->pauseAnimations();
134 } 134 }
135 135
136 void SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements() 136 void SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements()
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 { 361 {
362 visitor->trace(m_document); 362 visitor->trace(m_document);
363 visitor->trace(m_timeContainers); 363 visitor->trace(m_timeContainers);
364 visitor->trace(m_webAnimationsPendingSVGElements); 364 visitor->trace(m_webAnimationsPendingSVGElements);
365 visitor->trace(m_relativeLengthSVGRoots); 365 visitor->trace(m_relativeLengthSVGRoots);
366 visitor->trace(m_pendingResources); 366 visitor->trace(m_pendingResources);
367 visitor->trace(m_pendingResourcesForRemoval); 367 visitor->trace(m_pendingResourcesForRemoval);
368 } 368 }
369 369
370 } // namespace blink 370 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698