[interpreter] Add CreateBlockContext bytecode

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include "src/ast/scopes.h"
 #include "src/code-stubs.h"
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-flags.h"
@@ skipping 3193 matching lines @@
     DCHECK_EQ(0, scope->ContextChainLength(variable->scope()));
     builder()->LoadAccumulatorWithRegister(parameter)
         .StoreContextSlot(execution_context()->reg(), variable->index());
   }
 }
 
 void BytecodeGenerator::VisitNewLocalBlockContext(Scope* scope) {
   AccumulatorResultScope accumulator_execution_result(this);
   DCHECK(scope->is_block_scope());
 
-  // Allocate a new local block context.
-  register_allocator()->PrepareForConsecutiveAllocations(2);
-  Register scope_info = register_allocator()->NextConsecutiveRegister();
-  Register closure = register_allocator()->NextConsecutiveRegister();
+  size_t scope_info = builder()->AllocateConstantPoolEntry();
+  builder()->InsertConstantPoolEntryAt(scope_info,
+                                       scope->GetScopeInfo(isolate()));

[rmcilroy, 2016/08/15 16:01:04]

Don't use AllocateConstantPoolEntry() (That's only for when you need to allocate
something which you don't yet have the Handle for and will be filled in later).
Instead just pass the Handle<ScopeInfo> to the bytecode builder and do
GetConstantPoolEntry there (e.g., see LoadLiteral(Handle<Object>)

[klaasb, 2016/08/16 10:40:09]

Done.

+  VisitFunctionClosureForContext();
 
-  builder()
-      ->LoadLiteral(scope->GetScopeInfo(isolate()))
-      .StoreAccumulatorInRegister(scope_info);
-  VisitFunctionClosureForContext();
-  builder()
-      ->StoreAccumulatorInRegister(closure)
-      .CallRuntime(Runtime::kPushBlockContext, scope_info, 2);
+  builder()->CreateBlockContext(scope_info);
   execution_result()->SetResultInAccumulator();
 }
 
 void BytecodeGenerator::VisitNewLocalWithContext() {
   AccumulatorResultScope accumulator_execution_result(this);
 
   register_allocator()->PrepareForConsecutiveAllocations(2);
   Register extension_object = register_allocator()->NextConsecutiveRegister();
   Register closure = register_allocator()->NextConsecutiveRegister();
 
@@ skipping 195 matching lines @@
   return execution_context()->scope()->language_mode();
 }
 
 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
   return TypeFeedbackVector::GetIndex(slot);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8