Force release the worker ref count to release the process in BrowserContext::NotifyWillBeDestroyed()

Force release the worker ref count to release the process in BrowserContext::NotifyWillBeDestroyed()

See: https://crbug.com/636377#c11

BUG=636377

[horo, 2016-08-15 09:17:35]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 09:17:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 09:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 09:47:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-08-15 11:07:54]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 11:07:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-08-15 11:26:13]

Description was changed from

==========
wip

BUG=
==========

to

==========
Release the worker refcount in BrowserContext::NotifyWillBeDestroyed()

BUG=636377
==========

[commit-bot: I haz the power, 2016-08-15 11:31:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 11:31:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[horo, 2016-08-15 15:17:41]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 15:17:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 16:01:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 16:01:35]

Dry run: Exceeded global retry quota

[horo, 2016-08-16 04:45:32]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 04:45:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 05:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 05:19:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-08-16 08:36:22]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 08:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-08-16 08:55:08]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 08:55:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-08-16 08:57:38]

Patchset #4 (id:60001) has been deleted

[horo, 2016-08-16 08:57:39]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 08:57:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-08-16 09:38:26]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 09:38:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-08-16 09:41:13]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 09:41:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 10:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 10:58:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-08-16 11:59:48]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 11:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 12:50:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 12:50:22]

Dry run: This issue passed the CQ dry run.

[horo, 2016-08-16 12:55:31]

Patchset #4 (id:80001) has been deleted

[horo, 2016-08-16 12:55:35]

Patchset #3 (id:40001) has been deleted

[horo, 2016-08-16 12:55:38]

Patchset #2 (id:20001) has been deleted

[horo, 2016-08-16 12:55:41]

Patchset #1 (id:1) has been deleted

[horo, 2016-08-16 12:56:00]

Patchset #1 (id:100001) has been deleted

[horo, 2016-08-16 12:58:46]

Description was changed from

==========
Release the worker refcount in BrowserContext::NotifyWillBeDestroyed()

BUG=636377
==========

to

==========
Force release the worker ref count to release the process in
BrowserContext::NotifyWillBeDestroyed()

BUG=636377
==========

[alokp, 2016-08-16 13:19:46]

alokp@chromium.org changed reviewers:
+ alokp@chromium.org

[alokp, 2016-08-16 13:19:47]

https://codereview.chromium.org/2248583003/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc (right):

https://codereview.chromium.org/2248583003/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc:25:
content::TestBrowserThreadBundle thread_bundle_;
does thread_bundle_ need to outlive profile_?

[horo, 2016-08-16 13:39:10]

https://codereview.chromium.org/2248583003/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc (right):

https://codereview.chromium.org/2248583003/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc:25:
content::TestBrowserThreadBundle thread_bundle_;
On 2016/08/16 13:19:47, alokp wrote:
> does thread_bundle_ need to outlive profile_?

yes.
Without thread_bundle_, "DCHECK(current);" in ThreadTaskRunnerHandle::Get()
fails.

[21296:21296:0816/223402:1940575818456:FATAL:thread_task_runner_handle.cc(26)]
Check failed: current. 
#0 0x7effcc8a7e7e base::debug::StackTrace::StackTrace()
#1 0x7effcc90298c logging::LogMessage::~LogMessage()
#2 0x7effcca543d7 base::ThreadTaskRunnerHandle::Get()
#3 0x7effcca3d2f8 base::SequencedWorkerPool::SequencedWorkerPool()
#4 0x7effc77ea530 content::(anonymous
namespace)::BrowserThreadGlobals::BrowserThreadGlobals()
#5 0x7effc77ea4aa base::DefaultLazyInstanceTraits<>::New()
#6 0x7effc77ea3b5 base::internal::LeakyLazyInstanceTraits<>::New()
#7 0x7effc77ea36d base::LazyInstance<>::Pointer()
#8 0x7effc77e8275 base::LazyInstance<>::Get()
#9 0x7effc77e993d content::BrowserThread::CurrentlyOn()
#10 0x7effc77bc884 content::BrowserContext::NotifyWillBeDestroyed()
#11 0x000004bda9c4 Profile::MaybeSendDestroyedNotification()
#12 0x00000423ed13 TestingProfile::~TestingProfile()
#13 0x00000423f039 TestingProfile::~TestingProfile()

[horo, 2016-08-16 15:16:10]

Description was changed from

==========
Force release the worker ref count to release the process in
BrowserContext::NotifyWillBeDestroyed()

BUG=636377
==========

to

==========
Force release the worker ref count to release the process in
BrowserContext::NotifyWillBeDestroyed()

See: https://crbug.com/636377#c11

BUG=636377
==========

[horo, 2016-08-17 02:22:06]

I created a CL which will remove the reference from the all documents in
the renderer process to shared workers when |isteners_| is empty in
RenderProcessHostImpl::Cleanup().
https://codereview.chromium.org/2249173003/

I think this is more straight forward and less complex.