Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2248583002: Add a missing include to translation_unit - required after the roll to clang r277962. (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing include to translation_unit - required after the roll to clang r277962. BUG=637317 TBR=thakis Committed: https://chromium.googlesource.com/chromium/src/+/f44c5e7a7d5f7a592ea8bd1750789d51c09cd344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/clang/translation_unit/TranslationUnitGenerator.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dsansome
4 years, 4 months ago (2016-08-15 04:13:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248583002/1
4 years, 4 months ago (2016-08-15 04:13:27 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-15 04:13:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248583002/1
4 years, 4 months ago (2016-08-15 04:16:38 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-15 04:16:40 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f44c5e7a7d5f7a592ea8bd1750789d51c09cd344 Cr-Commit-Position: refs/heads/master@{#411938}
4 years, 4 months ago (2016-08-15 04:22:08 UTC) #13
dsansome
Committed patchset #1 (id:1) manually as f44c5e7a7d5f7a592ea8bd1750789d51c09cd344 (presubmit successful).
4 years, 4 months ago (2016-08-15 04:23:10 UTC) #15
Nico
4 years, 4 months ago (2016-08-22 21:24:54 UTC) #16
Message was sent while issue was closed.
lgtm, thanks much for handling this!

Powered by Google App Engine
This is Rietveld 408576698