Add Inspector Agent for WebPerf, add probes in V8ScriptRunner.

Add Inspector Agent for WebPerf, add probes in V8ScriptRunner.
This will be used by Long Task Observer.

BUG=635596
Committed: https://crrev.com/7b902d5b18efcdab2c996c619a342d18e16221c3
Cr-Commit-Position: refs/heads/master@{#412406}

[panicker, 2016-08-15 15:18:24]

panicker@chromium.org changed reviewers:
+ caseq@chromium.org

[panicker, 2016-08-15 15:18:25]

Hey Andrey, mind reviewing this CL?

I have a question about why methods in the IDL cannot have empty params, for
instance I'd rather not pass any args to didExecuteScript(..).

[pfeldman, 2016-08-15 17:59:54]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-08-15 17:59:55]

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:407:
InspectorInstrumentation::willExecuteScript(
Here and below: you can pass |context| here, it'll resolve to the instrumenting
agent within frame or worker.

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:415: return
v8::MaybeLocal<v8::Value>();
This will break your will* and did* apart, lets place them next to the
ThreadDebugger:: ones below.

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
(right):

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:314: void
willExecuteScript([Keep] LocalFrame* frame);
[Keep] ExecutionContext

[panicker, 2016-08-15 20:48:55]

Thanks for the review!
PTAL.

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:407:
InspectorInstrumentation::willExecuteScript(
On 2016/08/15 17:59:55, pfeldman wrote:
> Here and below: you can pass |context| here, it'll resolve to the
instrumenting
> agent within frame or worker.

Done.

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:415: return
v8::MaybeLocal<v8::Value>();
On 2016/08/15 17:59:55, pfeldman wrote:
> This will break your will* and did* apart, lets place them next to the
> ThreadDebugger:: ones below.

Done.

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
(right):

https://codereview.chromium.org/2248553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:314: void
willExecuteScript([Keep] LocalFrame* frame);
On 2016/08/15 17:59:55, pfeldman wrote:
> [Keep] ExecutionContext

Done.

[pfeldman, 2016-08-15 21:10:12]

lgtm

[panicker, 2016-08-15 22:05:45]

The CQ bit was checked by panicker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 22:06:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 02:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 02:24:48]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[caseq, 2016-08-16 18:19:55]

lgtm

https://codereview.chromium.org/2248553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h (right):

https://codereview.chromium.org/2248553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:18: class
CORE_EXPORT InspectorWebPerfAgent final : public InspectorAgent {
Let's stop inheriting InspectorAgent altogether? I think we don't have to -- we
used to think of agents as (1) protocol endpoints and (2) instrumenting agents,
and so far they were mostly both (1) and (2), but at least (1), and now this
introduces a case of agent that is just (2). The good news is that the interface
of InspectorAgent is just for managing protocol endpoints, and
InspectorInstrumentation should work for you even if you're not inheriting
InspectorAgent. So just make it
GarbageCollectedFinalized<InspectorWebPerfAgent>.

[panicker, 2016-08-16 20:28:36]

On 2016/08/16 18:19:55, caseq wrote:
> lgtm
> 
>
https://codereview.chromium.org/2248553002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h (right):
> 
>
https://codereview.chromium.org/2248553002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:18: class
> CORE_EXPORT InspectorWebPerfAgent final : public InspectorAgent {
> Let's stop inheriting InspectorAgent altogether? I think we don't have to --
we
> used to think of agents as (1) protocol endpoints and (2) instrumenting
agents,
> and so far they were mostly both (1) and (2), but at least (1), and now this
> introduces a case of agent that is just (2). The good news is that the
interface
> of InspectorAgent is just for managing protocol endpoints, and
> InspectorInstrumentation should work for you even if you're not inheriting
> InspectorAgent. So just make it
> GarbageCollectedFinalized<InspectorWebPerfAgent>.

Ok, removing inheriting from InspectorAgent. As you say, there is no good reason
to.

[panicker, 2016-08-16 20:30:58]

The CQ bit was checked by panicker@chromium.org

[panicker, 2016-08-16 20:30:58]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2248553002/#ps40001
(title: "remove inheritance from InspectorAgent")

[commit-bot: I haz the power, 2016-08-16 20:31:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 23:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:09:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[panicker, 2016-08-16 23:59:42]

The CQ bit was checked by panicker@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:00:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-08-17 01:05:20]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-08-17 01:05:20]

Oilpan part LGTM

https://codereview.chromium.org/2248553002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h (right):

https://codereview.chromium.org/2248553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:18: class
CORE_EXPORT InspectorWebPerfAgent final : public
GarbageCollectedFinalized<InspectorWebPerfAgent> {

GarbageCollectedFinalized => GarbageCollected

https://codereview.chromium.org/2248553002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:21:
InspectorWebPerfAgent(InspectedFrames*);

Add explicit

[commit-bot: I haz the power, 2016-08-17 01:12:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 01:14:42]

Description was changed from

==========
Add Inspector Agent for WebPerf, add probes in V8ScriptRunner.
This will be used by Long Task Observer.

BUG=635596
==========

to

==========
Add Inspector Agent for WebPerf, add probes in V8ScriptRunner.
This will be used by Long Task Observer.

BUG=635596

Committed: https://crrev.com/7b902d5b18efcdab2c996c619a342d18e16221c3
Cr-Commit-Position: refs/heads/master@{#412406}
==========

[commit-bot: I haz the power, 2016-08-17 01:14:43]

Patchset 3 (id:??) landed as
https://crrev.com/7b902d5b18efcdab2c996c619a342d18e16221c3
Cr-Commit-Position: refs/heads/master@{#412406}

[panicker, 2016-08-17 18:08:33]

On 2016/08/17 01:05:20, haraken wrote:
> Oilpan part LGTM
> 
>
https://codereview.chromium.org/2248553002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h (right):
> 
>
https://codereview.chromium.org/2248553002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:18: class
> CORE_EXPORT InspectorWebPerfAgent final : public
> GarbageCollectedFinalized<InspectorWebPerfAgent> {
> 
> GarbageCollectedFinalized => GarbageCollected
> 
>
https://codereview.chromium.org/2248553002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:21:
> InspectorWebPerfAgent(InspectedFrames*);
> 
> Add explicit

I'll send a follow up CL with the fixes (as this was already in commit queue).
Thanks for the comments!