Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2248533002:
Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ni… (Closed)
|
Created:
4 years, 4 months ago by robertphillips Modified:
4 years, 4 months ago Reviewers:
bsalomon CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionUpdate ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws
This is split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248533002
Committed: https://skia.googlesource.com/skia/+/c4d2f907311fca08303c254b2488bd7990fa2f32
Patch Set 1 #Patch Set 2 : clean up #Patch Set 3 : Spruce up test #Patch Set 4 : Fix test #Patch Set 5 : SK_ARRAY_COUNT still returns the wrong type #Patch Set 6 : update to ToT #Patch Set 7 : Fix bug #
Total comments: 2
Patch Set 8 : Fix indentation #
Messages
Total messages: 36 (30 generated)
Description was changed from ========== Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws This is split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) ========== to ========== Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws This is split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248533002 ==========
Description was changed from ========== Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws This is split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248533002 ========== to ========== Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws This is split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248533002 ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robertphillips@google.com changed reviewers: + bsalomon@google.com
ping
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2248533002/diff/120001/src/effects/SkBlurMask... File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/2248533002/diff/120001/src/effects/SkBlurMask... src/effects/SkBlurMaskFilter.cpp:156: SkScalar lower, SkScalar higher, align?
https://codereview.chromium.org/2248533002/diff/120001/src/effects/SkBlurMask... File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/2248533002/diff/120001/src/effects/SkBlurMask... src/effects/SkBlurMaskFilter.cpp:156: SkScalar lower, SkScalar higher, On 2016/08/16 14:30:02, bsalomon wrote: > align? Done.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/2248533002/#ps140001 (title: "Fix indentation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws This is split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248533002 ========== to ========== Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws This is split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248533002 Committed: https://skia.googlesource.com/skia/+/c4d2f907311fca08303c254b2488bd7990fa2f32 ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/c4d2f907311fca08303c254b2488bd7990fa2f32 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
