Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2248443002: Revert of Add logcats link in builbot page for android swarming tasks (Closed)

Created:
4 years, 4 months ago by nicholaslin
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Add logcats link in builbot page for android swarming tasks (patchset #10 id:180001 of https://codereview.chromium.org/2207263002/ ) Reason for revert: populating empty links. Original issue's description: > Add logcats link in builbot page for android swarming tasks > > BUG=chromium:448050 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/c9c68ee6bcf16f9b5e3b0a9a34e4720ebf9d0126 TBR=martiniss@chromium.org,stip@chromium.org,phajdan.jr@chromium.org,sergeyberezin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:448050 Committed: https://chromium.googlesource.com/chromium/tools/build/+/ccc7e42c27474fa3671625527ceb9ff49676886c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1344 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/steps.py View 8 chunks +5 lines, -29 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 1 chunk +2 lines, -106 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json View 1 chunk +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/dynamic_swarmed_no_output_trigger_test.json View 1 chunk +0 lines, -598 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/dynamic_swarmed_output_links_trigger_test.json View 1 chunk +0 lines, -609 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nicholaslin
Created Revert of Add logcats link in builbot page for android swarming tasks
4 years, 4 months ago (2016-08-13 00:06:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248443002/1
4 years, 4 months ago (2016-08-13 00:06:39 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-13 00:06:40 UTC) #5
Sergey Berezin
lgtm
4 years, 4 months ago (2016-08-13 00:12:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248443002/1
4 years, 4 months ago (2016-08-15 20:11:42 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:11:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/ccc7e42c27474fa36716...

Powered by Google App Engine
This is Rietveld 408576698