src/d8.cc - Issue 2248393002: Replace DumpBacktrace with Chromium's StackTrace implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 2248393002: Replace DumpBacktrace with Chromium's StackTrace implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address Comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index cc4ac7d4d7b68aedc6fc74c37966ace2d325dd61..a8af9de2d17a2b11359bc1d798a27090ba3bb598 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -39,6 +39,7 @@

#ifndef V8_SHARED

#include "src/api.h"

#include "src/base/cpu.h"

+#include "src/base/debug/stack_trace.h"

#include "src/base/logging.h"

#include "src/base/platform/platform.h"

#include "src/base/sys-info.h"

@@ -2538,6 +2539,9 @@ static void DumpHeapConstants(i::Isolate* isolate) {

int Shell::Main(int argc, char* argv[]) {

std::ofstream trace_file;

+#ifndef V8_SHARED

+ v8::base::debug::EnableInProcessStackDumping();

+#endif

#if (defined(_WIN32) || defined(_WIN64))

UINT new_flags =

SEM_FAILCRITICALERRORS | SEM_NOGPFAULTERRORBOX | SEM_NOOPENFILEERRORBOX;

« no previous file with comments | « src/base/logging.cc ('k') | src/v8.gyp » ('j') | no next file with comments »