Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: BUILD.gn

Issue 2248393002: Replace DumpBacktrace with Chromium's StackTrace implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address Comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/base/debug/stack_trace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index bc772e329c3a00a6f8ef5ef601c1e63bfb3b4fd2..2207ddae1aa5f091bc9420e8c37ed7e92468034c 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2036,12 +2036,15 @@ v8_source_set("v8_libbase") {
"src/base/build_config.h",
"src/base/cpu.cc",
"src/base/cpu.h",
+ "src/base/debug/stack_trace.cc",
+ "src/base/debug/stack_trace.h",
"src/base/division-by-constant.cc",
"src/base/division-by-constant.h",
"src/base/file-utils.cc",
"src/base/file-utils.h",
"src/base/flags.h",
"src/base/format-macros.h",
+ "src/base/free_deleter.h",
"src/base/functional.cc",
"src/base/functional.h",
"src/base/hashmap.h",
@@ -2079,11 +2082,16 @@ v8_source_set("v8_libbase") {
defines = []
if (is_posix) {
- sources += [ "src/base/platform/platform-posix.cc" ]
+ sources += [
+ "src/base/platform/platform-posix.cc",
+ ]
}
if (is_linux) {
- sources += [ "src/base/platform/platform-linux.cc" ]
+ sources += [
+ "src/base/debug/stack_trace_posix.cc",
+ "src/base/platform/platform-linux.cc",
+ ]
libs = [
"dl",
@@ -2096,18 +2104,31 @@ v8_source_set("v8_libbase") {
"rt",
]
if (host_os == "mac") {
- sources += [ "src/base/platform/platform-macos.cc" ]
+ sources += [
+ "src/base/debug/stack_trace_posix.cc",
+ "src/base/platform/platform-macos.cc",
+ ]
} else {
- sources += [ "src/base/platform/platform-linux.cc" ]
+ sources += [
+ "src/base/debug/stack_trace_posix.cc",
+ "src/base/platform/platform-linux.cc",
+ ]
}
} else {
- sources += [ "src/base/platform/platform-linux.cc" ]
+ sources += [
+ "src/base/debug/stack_trace_android.cc",
+ "src/base/platform/platform-linux.cc",
+ ]
}
} else if (is_mac) {
- sources += [ "src/base/platform/platform-macos.cc" ]
+ sources += [
+ "src/base/debug/stack_trace_posix.cc",
+ "src/base/platform/platform-macos.cc",
+ ]
} else if (is_win) {
# TODO(jochen): Add support for cygwin.
sources += [
+ "src/base/debug/stack_trace_win.cc",
"src/base/platform/platform-win32.cc",
"src/base/win32-headers.h",
]
@@ -2115,6 +2136,8 @@ v8_source_set("v8_libbase") {
defines += [ "_CRT_RAND_S" ] # for rand_s()
libs = [
+ "dbghelp.lib",
+ "shlwapi.lib",
"winmm.lib",
"ws2_32.lib",
]
« no previous file with comments | « no previous file | src/base/debug/stack_trace.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698