Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: src/v8.gyp

Issue 2248393002: Replace DumpBacktrace with Chromium's StackTrace implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/base/free_deleter.h ('K') | « src/d8.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index 9ca8b4c8fcc4dfc490a6d8ae16b541885054475d..c3e888c43786550c929df45f0f6235044f51d7e7 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -1767,10 +1767,13 @@
'base/cpu.h',
'base/division-by-constant.cc',
'base/division-by-constant.h',
+ 'base/debug/stack_trace.cc',
+ 'base/debug/stack_trace.h',
'base/file-utils.cc',
'base/file-utils.h',
'base/flags.h',
'base/format-macros.h',
+ 'base/free_deleter.h',
'base/functional.cc',
'base/functional.h',
'base/hashmap.h',
@@ -1818,13 +1821,15 @@
},
'sources': [
'base/platform/platform-linux.cc',
- 'base/platform/platform-posix.cc'
+ 'base/platform/platform-posix.cc',
+ 'base/debug/stack_trace_posix.cc'
Jakob Kummerow 2016/08/18 09:36:13 nit: "d" alpha-sorts before "p", again several tim
rmcilroy 2016/08/18 11:39:48 Done.
],
}
],
['OS=="android"', {
'sources': [
- 'base/platform/platform-posix.cc'
+ 'base/platform/platform-posix.cc',
+ 'base/debug/stack_trace_android.cc'
],
'link_settings': {
'target_conditions': [
@@ -1879,7 +1884,8 @@
},
'sources': [
'base/platform/platform-posix.cc',
- 'base/qnx-math.h',
+ 'base/debug/stack_trace_posix.cc',
+ 'base/qnx-math.h'
],
'target_conditions': [
['_toolset=="host" and host_os=="linux"', {
@@ -1907,7 +1913,8 @@
]},
'sources': [
'base/platform/platform-freebsd.cc',
- 'base/platform/platform-posix.cc'
+ 'base/platform/platform-posix.cc',
+ 'base/debug/stack_trace_posix.cc'
],
}
],
@@ -1929,7 +1936,8 @@
]},
'sources': [
'base/platform/platform-openbsd.cc',
- 'base/platform/platform-posix.cc'
+ 'base/platform/platform-posix.cc',
+ 'base/debug/stack_trace_posix.cc'
],
}
],
@@ -1946,14 +1954,16 @@
]},
'sources': [
'base/platform/platform-solaris.cc',
- 'base/platform/platform-posix.cc'
+ 'base/platform/platform-posix.cc',
+ 'base/debug/stack_trace_posix.cc'
],
}
],
['OS=="mac"', {
'sources': [
'base/platform/platform-macos.cc',
- 'base/platform/platform-posix.cc'
+ 'base/platform/platform-posix.cc',
+ 'base/debug/stack_trace_posix.cc'
]},
],
['OS=="win"', {
@@ -1972,11 +1982,13 @@
['build_env=="Cygwin"', {
'sources': [
'base/platform/platform-cygwin.cc',
- 'base/platform/platform-posix.cc'
+ 'base/platform/platform-posix.cc',
+ 'base/debug/stack_trace_posix.cc'
],
}, {
'sources': [
'base/platform/platform-win32.cc',
+ 'base/debug/stack_trace_win.cc',
'base/win32-headers.h',
],
}],
@@ -1987,11 +1999,17 @@
}, {
'sources': [
'base/platform/platform-win32.cc',
+ 'base/debug/stack_trace_win.cc',
'base/win32-headers.h',
],
'msvs_disabled_warnings': [4351, 4355, 4800],
'link_settings': {
- 'libraries': [ '-lwinmm.lib', '-lws2_32.lib' ],
+ 'libraries': [
+ '-ldbghelp.lib',
+ '-lshlwapi.lib',
+ '-lwinmm.lib',
+ '-lws2_32.lib'
+ ],
},
}],
],
« src/base/free_deleter.h ('K') | « src/d8.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698