Moves HeaderView into it's own .h/.cc

Moves HeaderView into it's own .h/.cc

This way I can use it outside of CustomFrameViewAsh.

BUG=548435
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/c11a6807f5cbfe02017dae138a3da2acd6e6f853
Cr-Commit-Position: refs/heads/master@{#412635}

[sky, 2016-08-17 19:44:53]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-17 20:06:05]

LGTM with a couple comment/naming thoughts.

https://codereview.chromium.org/2248383003/diff/20001/ash/common/frame/header...
File ash/common/frame/header_view.h (right):

https://codereview.chromium.org/2248383003/diff/20001/ash/common/frame/header...
ash/common/frame/header_view.h:34: // necessarily the same as the widget the
header is placed in.
nit: I would expand on this with something like:

For example, in immersive fullscreen this view may be painted in a widget that
slides in and out on top of the main app or browser window. However, clicking a
caption button should act on the underlying window.

https://codereview.chromium.org/2248383003/diff/20001/ash/common/frame/header...
ash/common/frame/header_view.h:35: explicit HeaderView(views::Widget* frame);
What do you think of calling this something like target_widget or
underlying_widget?

[sky, 2016-08-17 20:20:24]

https://codereview.chromium.org/2248383003/diff/20001/ash/common/frame/header...
File ash/common/frame/header_view.h (right):

https://codereview.chromium.org/2248383003/diff/20001/ash/common/frame/header...
ash/common/frame/header_view.h:34: // necessarily the same as the widget the
header is placed in.
On 2016/08/17 20:06:04, James Cook (slow reviews) wrote:
> nit: I would expand on this with something like:
> 
> For example, in immersive fullscreen this view may be painted in a widget that
> slides in and out on top of the main app or browser window. However, clicking
a
> caption button should act on the underlying window.

Done.

https://codereview.chromium.org/2248383003/diff/20001/ash/common/frame/header...
ash/common/frame/header_view.h:35: explicit HeaderView(views::Widget* frame);
On 2016/08/17 20:06:04, James Cook (slow reviews) wrote:
> What do you think of calling this something like target_widget or
> underlying_widget?

I went with target_widget.

[sky, 2016-08-17 20:21:03]

The CQ bit was checked by sky@chromium.org

[sky, 2016-08-17 20:21:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2248383003/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2016-08-17 20:21:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:00:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 21:05:40]

Description was changed from

==========
Moves HeaderView into it's own .h/.cc

This way I can use it outside of CustomFrameViewAsh.

BUG=548435
TEST=none
R=jamescook@chromium.org
==========

to

==========
Moves HeaderView into it's own .h/.cc

This way I can use it outside of CustomFrameViewAsh.

BUG=548435
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/c11a6807f5cbfe02017dae138a3da2acd6e6f853
Cr-Commit-Position: refs/heads/master@{#412635}
==========

[commit-bot: I haz the power, 2016-08-17 21:05:41]

Patchset 3 (id:??) landed as
https://crrev.com/c11a6807f5cbfe02017dae138a3da2acd6e6f853
Cr-Commit-Position: refs/heads/master@{#412635}