Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 2248353002: [M53 cherry-pick] Migrate ArcUserDataService into ArcAuthService. (Closed)

Created:
4 years, 4 months ago by hidehiko
Modified:
4 years, 4 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Migrate ArcUserDataService into ArcAuthService. There are race problems around data removing. One of the cause is that state management is done in ArcAuthService and ArcUserDataService separately. This CL migrates ArcUserDataService into ArcAuthService so that we can remove the data when necessary. BUG=633258, 636218 TEST=Ran manually. - "Enable -> ARC boot wait -> Disable" triggers data removal after ARC stop. - "Enable -> Disable before ARC boot" triggers immediate data removal. - "Enable -> ARC boot wait -> Kill ARC instance" does not trigger data removal. R=dspaid@chromium.org, lhchavez@chromium.org TBR=khmel@chromium.org, lhchavez@chromium.org, stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2209173002 Cr-Commit-Position: refs/heads/master@{#411923} (cherry picked from commit 6d95ad318e992261c45f5a88a0a599663a6d66ae) Committed: https://chromium.googlesource.com/chromium/src/+/d7ca35a59c7bd8c7ddd78d7682458e48e6b4e934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -33 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 5 chunks +53 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service_unittest.cc View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_enterprise_reporting_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_enterprise_reporting_service.cc View 1 chunk +2 lines, -15 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M components/arc/arc_service_manager.h View 3 chunks +0 lines, -6 lines 0 comments Download
M components/arc/arc_service_manager.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hidehiko
This is M53 cherry pick. https://codereview.chromium.org/2248353002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc L460 is the only conflict line. Dan, PTAL for ...
4 years, 4 months ago (2016-08-17 09:52:23 UTC) #4
Luis Héctor Chávez
rs-lgtm
4 years, 4 months ago (2016-08-17 15:20:37 UTC) #5
dspaid
lgtm
4 years, 4 months ago (2016-08-17 22:58:12 UTC) #6
hidehiko
Thank you for review. Landing. TBR=stevenjb, kheml (no diff from original CL).
4 years, 4 months ago (2016-08-18 04:20:35 UTC) #7
hidehiko
Committed patchset #1 (id:1) manually as d7ca35a59c7bd8c7ddd78d7682458e48e6b4e934.
4 years, 4 months ago (2016-08-18 04:25:39 UTC) #9
khmel
4 years, 4 months ago (2016-08-18 22:20:03 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2255673004/ by khmel@chromium.org.

The reason for reverting is: Compilation problem:

../../chrome/browser/chromeos/arc/arc_auth_service.cc:244:34: error: no member
named 'stopped' in 'arc::ArcBridgeService'.

Powered by Google App Engine
This is Rietveld 408576698