Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2248343004: Add SpdyDeframerVisitor. (Closed)

Created:
4 years, 4 months ago by Bence
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SpdyDeframerVisitor. SpdyDeframerVisitor reconstructs SpdyFrameIR instances from callbacks to SpdyFramerVisitorInterface. This CL lands server changes 122860864, 122867216, 126441874, and 126727481 by jamessynge. BUG=488484 Committed: https://crrev.com/42dc140ebb986b2f3047efc78cb8195aa05c8335 Cr-Commit-Position: refs/heads/master@{#412805}

Patch Set 1 #

Patch Set 2 : Fix MSVC compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1980 lines, -6 lines) Patch
M net/net.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
A net/spdy/spdy_deframer_visitor.h View 1 chunk +250 lines, -0 lines 0 comments Download
A net/spdy/spdy_deframer_visitor.cc View 1 chunk +1098 lines, -0 lines 0 comments Download
A net/spdy/spdy_deframer_visitor_test.cc View 1 1 chunk +273 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +6 lines, -6 lines 0 comments Download
A net/spdy/spdy_protocol_test_utils.h View 1 chunk +160 lines, -0 lines 0 comments Download
A net/spdy/spdy_protocol_test_utils.cc View 1 chunk +188 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 4 months ago (2016-08-17 18:20:25 UTC) #8
Ryan Hamilton
lgtm Wow, cool!
4 years, 4 months ago (2016-08-17 19:30:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248343004/20001
4 years, 4 months ago (2016-08-18 12:14:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 12:18:29 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 12:20:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42dc140ebb986b2f3047efc78cb8195aa05c8335
Cr-Commit-Position: refs/heads/master@{#412805}

Powered by Google App Engine
This is Rietveld 408576698