|
|
DescriptionFix CUPS compilation error in OSX 10.12.
BUG=622493
Committed: https://crrev.com/29c1262dbd4f749dd514d05a571cdd809ba8cfe0
Cr-Commit-Position: refs/heads/master@{#412670}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
pwnall@chromium.org changed reviewers: + skau@chromium.org
Per my comment in crbug.com/622493, this makes the CUPS-related 10.12 build errors go away. Please take a look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix CUPS compilation error in OSX 10.12. BUG=622493 ========== to ========== Fix CUPS compilation error in OSX 10.12. BUG=622493 ==========
skau@chromium.org changed reviewers: + thestig@chromium.org
On 2016/08/17 09:04:30, pwnall wrote: > Per my comment in crbug.com/622493, this makes the CUPS-related 10.12 build > errors go away. > > Please take a look? This looks okay to me. I double checked the CUPS sources and ppd.h hasn't been deleted *yet*. We don't have much of a choice until we can get to removing our PPD usage. I've added thestig@ since he owns this code.
lgtm
The CQ bit was checked by pwnall@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/17 17:46:35, skau wrote: > On 2016/08/17 09:04:30, pwnall wrote: > > Per my comment in crbug.com/622493, this makes the CUPS-related 10.12 build > > errors go away. > > > > Please take a look? > > This looks okay to me. I double checked the CUPS sources and ppd.h hasn't been > deleted *yet*. We don't have much of a choice until we can get to removing our > PPD usage. I've added thestig@ since he owns this code. Thank you for looking into this and for the quick turnaround!
Message was sent while issue was closed.
Description was changed from ========== Fix CUPS compilation error in OSX 10.12. BUG=622493 ========== to ========== Fix CUPS compilation error in OSX 10.12. BUG=622493 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix CUPS compilation error in OSX 10.12. BUG=622493 ========== to ========== Fix CUPS compilation error in OSX 10.12. BUG=622493 Committed: https://crrev.com/29c1262dbd4f749dd514d05a571cdd809ba8cfe0 Cr-Commit-Position: refs/heads/master@{#412670} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/29c1262dbd4f749dd514d05a571cdd809ba8cfe0 Cr-Commit-Position: refs/heads/master@{#412670} |