Implement DataCue interface.

Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

 /*
  * Copyright (c) 2013, Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
  * OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "V8TextTrackCue.h"
 
+#include "V8DataCue.h"
 #include "V8VTTCue.h"
 
 namespace WebCore {
 
 v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
-    return toV8(toVTTCue(impl), creationContext, isolate);
+    switch (impl->cueType()) {
+    case TextTrackCue::Data:
+        return toV8(toDataCue(impl), creationContext, isolate);
+    case TextTrackCue::WebVTT:
+        return toV8(toVTTCue(impl), creationContext, isolate);
+    default:

[acolwell GONE FROM CHROMIUM, 2014/04/04 23:25:27]

nit: Please remove default: code so a compiler error will occur if a new cue
type is added w/o this code getting updated.

[Brendan Long, 2014/05/28 16:31:48]

I get compile warnings if I remove it:

./../third_party/WebKit/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp: In
function ‘v8::Handle<v8::Value> WebCore::toV8(WebCore::TextTrackCue*,
v8::Handle<v8::Object>, v8::Isolate*)’:
../../third_party/WebKit/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp:46:1:
warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

+        ASSERT_NOT_REACHED();
+        return v8::Handle<v8::Value>();
+    }
 }
 
 } // namespace WebCore