Implement DataCue interface.

LayoutTests/media/video-test.js

 
 var video = null;
 var mediaElement = document; // If not set, an event from any element will trigger a waitForEvent() callback.
 var console = null;
 var printFullTestDetails = true; // This is optionaly switched of by test whose tested values can differ. (see disableFullTestDetailsPrinting())
 var Failed = false;
 
 var track = null; // Current TextTrack being tested.
 var cues = null; // Current TextTrackCueList being tested.
 var numberOfTrackTests = 0;
@@ skipping 70 matching lines @@
     var success = false;
     switch (comparison)
     {
         case '<':   success = observed <  expected; break;
         case '<=': success = observed <= expected; break;
         case '>':   success = observed >  expected; break;
         case '>=': success = observed >= expected; break;
         case '!=':  success = observed != expected; break;
         case '==': success = observed == expected; break;
         case '===': success = observed === expected; break;
+        case 'instanceof': success = observed instanceof expected; break;
     }
 
     reportExpected(success, testFuncString, comparison, expected, observed)
 }
 
 function testArraysEqual(testFuncString, expected)
 {
     var observed;
     try {
         observed = eval(testFuncString);
@@ skipping 108 matching lines @@
 }
 
 function testDOMException(testString, exceptionString)
 {
     try {
         eval(testString);
     } catch (ex) {
         var exception = ex;
     }
     logResult(exception instanceof DOMException && exception.code === eval(exceptionString),
-        "TEST(" + testString + ") THROWS(" + exceptionString + ": " + exception.message + ")");
+        "TEST(" + testString + ") THROWS(" + exceptionString + ": " + (exception ? exception.message : undefined) + ")");

[philipj_slow, 2014/04/04 14:54:33]

Unrelated change?

[Brendan Long, 2014/04/04 15:07:22]

This was necessary to make the test not crash if it fails (previously, if no
exception was through, 'exception' would be undefined and 'exception.message'
would cause a crash). I changed this to make it easier to write the tests, but I
think it's reasonable to leave it in place. I can remove it if you don't think
it should be here though.

 }
 
 function testException(testString, exceptionString) {
     try {
         eval(testString);
     } catch (ex) {
         var exception = ex;
     }
     logResult(exception !== undefined && exception == eval(exceptionString),
         "TEST(" + testString + ") THROWS(" + exceptionString + ")");
@@ skipping 127 matching lines @@
 
         func();
     }
 
     requiredEvents = [];
     for (var i = 0; i < eventList.length; i++) {
         requiredEvents[i] = eventList[i][1];
         eventList[i][0].addEventListener(requiredEvents[i], _eventCallback, true);
     }
 }