src/gpu/GrPrimitiveProcessor.h - Issue 2248323003: Simplify adding attributes to GrGeometryProcessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrPrimitiveProcessor.h

Issue 2248323003: Simplify adding attributes to GrGeometryProcessor (Closed) Base URL: https://chromium.googlesource.com/skia.git@xformhelper

Patch Set: Revert removal of fAttribNames Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrPrimitiveProcessor.h

diff --git a/src/gpu/GrPrimitiveProcessor.h b/src/gpu/GrPrimitiveProcessor.h

index d27a6f31c78d67390f42c06fc4783175b79da6b1..5239a868db13ba45738f5d614e848a91557504a1 100644

--- a/src/gpu/GrPrimitiveProcessor.h

+++ b/src/gpu/GrPrimitiveProcessor.h

@@ -156,8 +156,7 @@ public:

: fName(nullptr)

, fType(kFloat_GrVertexAttribType)

, fOffset(0) {}

- Attribute(const char* name, GrVertexAttribType type,

- GrSLPrecision precision = kDefault_GrSLPrecision)

+ Attribute(const char* name, GrVertexAttribType type, GrSLPrecision precision)

: fName(name)

, fType(type)

, fOffset(SkAlign4(GrVertexAttribTypeSize(type)))

« no previous file with comments | « src/gpu/GrOvalRenderer.cpp ('k') | src/gpu/batches/GrAAConvexPathRenderer.cpp » ('j') | no next file with comments »