Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2248323002:
Fix BUILD.gn for arch other then x86 and x64 (Closed)
|
Created:
4 years, 4 months ago by Ankur Mittal Modified:
4 years, 4 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionFix BUILD.gn for arch other then x86 and x64
opts_gypi should only be defined for x86 and x64 else we get unused
variable error
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248323002
Committed: https://skia.googlesource.com/skia/+/a7eaf2e7e84ff10d1ed76b5d1e039c1a2d931392
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixed accoring to mtklein's comments #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Fix BUILD.gn for arch other then x86 and x64 opts_gypi should only be defined for x86 and x64 else we get unused variable error BUG=skia: ========== to ========== Fix BUILD.gn for arch other then x86 and x64 opts_gypi should only be defined for x86 and x64 else we get unused variable error BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248323002 ==========
anmittal@google.com changed reviewers: + anmittal@google.com, mtklein@chromium.org
The CQ bit was checked by anmittal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
mtklein@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/2248323002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2248323002/diff/1/BUILD.gn#newcode150 BUILD.gn:150: if (is_x86) { Let's try to fix this differently, by adding opts_none here using sources=opts_gypi.none_sources and no extra cflags. Then we should depend on opts_none in an else branch of if (is_x86) { deps += ... } below.
The CQ bit was checked by anmittal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2248323002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2248323002/diff/1/BUILD.gn#newcode150 BUILD.gn:150: if (is_x86) { On 2016/08/17 12:43:39, mtklein wrote: > Let's try to fix this differently, by adding opts_none here using > sources=opts_gypi.none_sources and no extra cflags. > Then we should depend on opts_none in an else branch of if (is_x86) { deps += > ... } below. Done.
The CQ bit was unchecked by anmittal@google.com
The CQ bit was checked by mtklein@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix BUILD.gn for arch other then x86 and x64 opts_gypi should only be defined for x86 and x64 else we get unused variable error BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248323002 ========== to ========== Fix BUILD.gn for arch other then x86 and x64 opts_gypi should only be defined for x86 and x64 else we get unused variable error BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248323002 Committed: https://skia.googlesource.com/skia/+/a7eaf2e7e84ff10d1ed76b5d1e039c1a2d931392 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/a7eaf2e7e84ff10d1ed76b5d1e039c1a2d931392 |
