Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2393)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'webapk_updater_non_installable' into webapk_installable_checker Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index b25d564d663b6d50cfd32691a46bfdb8d2285565..0b81d91e34cdfcce7e6948fddf88c9837a1b6ccb 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -12,6 +12,8 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
#include "chrome/browser/android/shortcut_helper.h"
+#include "chrome/browser/android/webapk/chrome_webapk_host.h"
+#include "chrome/browser/android/webapk/webapk_web_manifest_checker.h"
#include "chrome/browser/banners/app_banner_metrics.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/manifest/manifest_icon_downloader.h"
@@ -154,6 +156,16 @@ void AppBannerManagerAndroid::PerformInstallableCheck() {
Stop();
}
+ if (ChromeWebApkHost::AreWebApkEnabled()) {
+ InstallableStatusCode error_code =
+ CheckWebManifestUrlsWebApkCompatible(manifest_);
+ if (error_code != NO_ERROR_DETECTED) {
+ ReportStatus(web_contents(), error_code);
dominickn 2016/08/24 03:27:11 When CheckWebManifestUrlsWebApkCompatible returns
+ Stop();
+ return;
+ }
+ }
+
// No native app banner was requested. Continue checking for a web app banner.
AppBannerManager::PerformInstallableCheck();
}

Powered by Google App Engine
This is Rietveld 408576698