chrome/browser/android/webapk/webapk_web_manifest_checker.h - Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/webapk/webapk_web_manifest_checker.h

Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'webapk_updater_non_installable' into webapk_installable_checker Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc ('K') | « chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc ('k') | chrome/browser/android/webapk/webapk_web_manifest_checker.cc » ('j') | chrome/browser/installable/installable_logging.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_WEB_MANIFEST_CHECKER_H_

	6 #define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_WEB_MANIFEST_CHECKER_H_

	7

	8 #include "chrome/browser/installable/installable_logging.h"

	9

	10 namespace content {

	11 struct Manifest;

	12 }

	13

	14 // Checks whether the format of the URLs in the Web Manifest is WebAPK

	15 // compatible. Returns NO_ERROR_DETECTED if it is compatible and the error code

	16 // otherwise.

	17 InstallableStatusCode CheckWebManifestUrlsWebApkCompatible(
	dominickn 2016/08/24 03:27:11 As per only having one status code for this method As per only having one status code for this method, make this return a bool, and remove the installable_logging.h include.
	18 const content::Manifest& manifest);

	19

	20 #endif // CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_WEB_MANIFEST_CHECKER_H_

OLD	NEW