Do not install WebAPKs with web manifests with invalid URL components

chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h"
 
 #include <jni.h>
 #include <vector>
 
 #include "base/android/jni_string.h"
 #include "chrome/browser/android/shortcut_helper.h"
 #include "chrome/browser/android/shortcut_info.h"
+#include "chrome/browser/android/webapk/webapk_web_manifest_checker.h"
 #include "chrome/browser/installable/installable_manager.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/manifest.h"
 #include "jni/ManifestUpgradeDetectorFetcher_jni.h"
 #include "third_party/smhasher/src/MurmurHash2.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "url/gurl.h"
 
@@ skipping 105 matching lines @@
   // links to the Web Manifest that we are looking for.
   // If the manifest URL is different from the current one, we will continue
   // observing too. It is based on our assumption that it is invalid for
   // web developers to change the Web Manifest location. When it does
   // change, we will treat the new Web Manifest as the one of another WebAPK.
   if (data.manifest.IsEmpty() || web_manifest_url_ != data.manifest_url)
     return;
 
   // TODO(pkotwicz): Tell Java side that the Web Manifest was fetched but the
   // Web Manifest is not WebAPK-compatible. (http://crbug.com/639536)
-  if (!data.is_installable)
+  if (CheckWebManifestUrlsWebApkCompatible(data.manifest) !=
+      NO_ERROR_DETECTED) {

[dominickn, 2016/08/24 03:27:11]

Do you still want to check data.installable here?

[pkotwicz, 2016/08/24 15:04:56]

Yes I do. Thank you for catching this bug!

     return;
+  }
 
   ShortcutInfo info(GURL::EmptyGURL());
   info.UpdateFromManifest(data.manifest);
   info.manifest_url = data.manifest_url;
   info.icon_url = data.icon_url;
   OnDataAvailable(info, (data.icon ? *data.icon : SkBitmap()));
 }
 
 void ManifestUpgradeDetectorFetcher::OnDataAvailable(
     const ShortcutInfo& info,
@@ skipping 17 matching lines @@
     // TODO(pkotwicz): Get hash of untransformed icon's bytes (with no
     // encoding/decoding).
     icon_murmur2_hash = ComputeBitmapHash(icon_bitmap);
   }
 
   Java_ManifestUpgradeDetectorFetcher_onDataAvailable(
       env, java_ref_, java_url, java_scope, java_name, java_short_name,
       java_icon_url, icon_murmur2_hash, java_bitmap, info.display,
       info.orientation, info.theme_color, info.background_color);
 }