Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2248283007: Delay creation of cpu-side buffer memory until actually needed (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delay creation of cpu-side buffer memory until actually needed IIUC what is going on, this won't really do anything bad but will defer allocation of the cpu-side buffer until it is actually needed. BUG=635015 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248283007 Committed: https://skia.googlesource.com/skia/+/48d91b52e4eb27f6bcb8eadb68558707a3c30875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/gpu/GrBufferAllocPool.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 4 months ago (2016-08-18 20:13:17 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-08-18 20:53:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248283007/1
4 years, 4 months ago (2016-08-18 21:00:20 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 21:01:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/48d91b52e4eb27f6bcb8eadb68558707a3c30875

Powered by Google App Engine
This is Rietveld 408576698