Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2248283006: Add additional_jar_files to inputs for java_library targets. (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additional_jar_files to inputs for java_library targets. BUG=638757 Committed: https://crrev.com/e990f984ef8d2bc49909351ec105dc2f3098f99a Cr-Commit-Position: refs/heads/master@{#413009}

Patch Set 1 #

Patch Set 2 : Add additional_jar_files to inputs for java_library targets. #

Patch Set 3 : Add additional_jar_files to inputs for java_library targets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M build/config/android/internal_rules.gni View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M build/config/android/rules.gni View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/robolectric/BUILD.gn View 2 chunks +25 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mikecase (-- gone --)
Hoping this will fix the downstream build issue. Also, these additional jar files probably should ...
4 years, 4 months ago (2016-08-18 19:52:03 UTC) #3
mikecase (-- gone --)
Hoping this will fix the downstream build issue. Also, these additional jar files probably should ...
4 years, 4 months ago (2016-08-18 19:52:03 UTC) #4
jbudorick
lgtm
4 years, 4 months ago (2016-08-18 19:54:14 UTC) #5
mikecase (-- gone --)
So this change is still a good change to make, but I was able to ...
4 years, 4 months ago (2016-08-18 21:25:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248283006/40001
4 years, 4 months ago (2016-08-18 22:54:12 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-19 01:35:25 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 01:38:23 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e990f984ef8d2bc49909351ec105dc2f3098f99a
Cr-Commit-Position: refs/heads/master@{#413009}

Powered by Google App Engine
This is Rietveld 408576698