Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2248263002: Add a padding between key and value in metadata box. (Closed)

Created:
4 years, 4 months ago by oka
Modified:
4 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: Add a padding between key and value in metadata box. BUG=632726 TEST=manually. Tested using Arabic too. Committed: https://crrev.com/bb8ff59eb557fb0c22a55d6f05ddc2c120742536 Cr-Commit-Position: refs/heads/master@{#412433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
oka
PTAL.
4 years, 4 months ago (2016-08-17 01:11:34 UTC) #2
fukino
lgtm
4 years, 4 months ago (2016-08-17 02:11:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248263002/1
4 years, 4 months ago (2016-08-17 02:17:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 02:52:40 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 02:54:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb8ff59eb557fb0c22a55d6f05ddc2c120742536
Cr-Commit-Position: refs/heads/master@{#412433}

Powered by Google App Engine
This is Rietveld 408576698