Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2248253002: Refresh Public Suffic List to the latest version (Closed)

Created:
4 years, 4 months ago by Ryan Sleevi
Modified:
4 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffic List to the latest version This updates from revision 28e17a0f8f26f1bddfbd62d9861b223efa7792bc (2016-07-06) to revision 4dcaacaf593dde7e2a34436913c24af3bf2bdb06 (2016-08-16) R=pkasting@chromium.org BUG=626532 Committed: https://crrev.com/702d65e434b5a41965f5b9fbe644e9e4300157b6 Cr-Commit-Position: refs/heads/master@{#412419}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -43 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 35 chunks +103 lines, -43 lines 6 comments Download

Messages

Total messages: 8 (2 generated)
Ryan Sleevi
The ICANN removals are because several TLD operators were unable to demonstrate they could be ...
4 years, 4 months ago (2016-08-17 00:48:17 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/2248253002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (left): https://codereview.chromium.org/2248253002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#oldcode7025 net/base/registry_controlled_domains/effective_tld_names.dat:7025: // africamagic : 2015-03-05 Electronic Media Network (Pty) ...
4 years, 4 months ago (2016-08-17 01:01:50 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/2248253002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/2248253002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode7306 net/base/registry_controlled_domains/effective_tld_names.dat:7306: // blog : 2015-05-14 On 2016/08/17 01:01:50, Peter Kasting ...
4 years, 4 months ago (2016-08-17 01:18:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248253002/1
4 years, 4 months ago (2016-08-17 01:19:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 01:59:14 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 02:01:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/702d65e434b5a41965f5b9fbe644e9e4300157b6
Cr-Commit-Position: refs/heads/master@{#412419}

Powered by Google App Engine
This is Rietveld 408576698