Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

Issue 2248243002: Enabling sampling of UMA and crash reports on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enabling sampling of UMA and crash reports on Android. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
index d21a02a6553a98b47f7835c725a31586d9081a56..2fe7bafe82beaf67fac5b8484338d63d706b32c6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
@@ -107,6 +107,11 @@ public class MinidumpUploadCallable implements Callable<Integer> {
Log.i(TAG, "Minidump cannot currently be uploaded due to constraints.");
return UPLOAD_FAILURE;
}
+
+ if (!mPermManager.isClientInMetricsSample()) {
+ Log.i(TAG, "Minidump cannot currently be uploaded due to sampling.");
+ return UPLOAD_FAILURE;
Alexei Svitkine (slow) 2016/08/18 06:16:39 Can you add a new enum for this case. I think it's
jwd 2016/08/23 18:40:03 Done.
+ }
}
HttpURLConnection connection =

Powered by Google App Engine
This is Rietveld 408576698