chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java - Issue 2248243002: Enabling sampling of UMA and crash reports on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java

Issue 2248243002: Enabling sampling of UMA and crash reports on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Theresa's and dfalcantara's comments with sync Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java

index 683ade1dcdc3060b37ef15b357f1fe68df434901..71a536ebf5618b9ddabab5d9aa913be22f4db64c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java

@@ -10,6 +10,7 @@ import android.preference.Preference.OnPreferenceChangeListener;

import android.preference.PreferenceFragment;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.metrics.UmaSessionStats;

import org.chromium.chrome.browser.preferences.ChromeSwitchPreference;

import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

@@ -39,16 +40,7 @@ public class UsageAndCrashReportsPreferenceFragment extends PreferenceFragment {

usageAndCrashReportsSwitch.setOnPreferenceChangeListener(new OnPreferenceChangeListener() {

@Override

public boolean onPreferenceChange(Preference preference, Object newValue) {

- boolean enabled = (boolean) newValue;

- PrivacyPreferencesManager privacyManager = PrivacyPreferencesManager.getInstance();

- // Update new two-choice android and chromium preferences.

- PrefServiceBridge.getInstance().setMetricsReportingEnabled(enabled);

- privacyManager.setUsageAndCrashReporting(enabled);

- // Update old three-choice android and chromium preference.

- PrefServiceBridge.getInstance().setCrashReportingEnabled(enabled);

- privacyManager.initCrashUploadPreference(enabled);

+ UmaSessionStats.changeMetricsReportingConsent((boolean) newValue);

return true;

}

});