Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Issue 2248223003: Fixes broken history page when no item selected (Closed)

Created:
4 years, 4 months ago by ahmetemirercin
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes broken history page when no item selected. There are situations where getSelectedList_ returns nothing and unselectAllItems triggered by polymer fails if nothing is selected.Page shifted downwards since polymer can't generate custom style for history-sidebar after the failure. BUG=637196 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/515e6066fbb3c7a44317ba86b8033a6c10ff03c4 Cr-Commit-Position: refs/heads/master@{#412780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
ahmetemirercin
4 years, 4 months ago (2016-08-17 06:42:28 UTC) #4
calamity
lgtm. Thanks for the patch.
4 years, 4 months ago (2016-08-18 05:12:49 UTC) #6
calamity
On 2016/08/18 05:12:49, calamity wrote: > lgtm. > > Thanks for the patch. I've changed ...
4 years, 4 months ago (2016-08-18 07:40:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248223003/1
4 years, 4 months ago (2016-08-18 09:51:37 UTC) #14
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 4 months ago (2016-08-18 10:02:38 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 10:05:25 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/515e6066fbb3c7a44317ba86b8033a6c10ff03c4
Cr-Commit-Position: refs/heads/master@{#412780}

Powered by Google App Engine
This is Rietveld 408576698