Issue 2248213003: Merged: [wasm] Require global names to be validate UTF-8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2248213003: Merged: [wasm] Require global names to be validate UTF-8. (Closed)

Created:
4 years, 4 months ago by titzer

Modified:
4 years, 4 months ago

Reviewers:
Michael Hablich

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.3

Target Ref:
refs/pending/branch-heads/5.3

Project:
v8

Visibility:
Public.

More Reviews

Description

Merged: [wasm] Require global names to be validate UTF-8. Revision: 6cf621ec891edb0c56ac1773a0fd57ee7a296713 BUG=chromium:628542 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/wasm/module-decoder.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

titzer

NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...

4 years, 4 months ago (2016-08-17 08:43:01 UTC) #2

Michael Hablich

On 2016/08/17 08:43:01, titzer wrote: > NOTE: This script will no longer automatically update include/v8-version.h ...

4 years, 4 months ago (2016-08-17 08:43:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248213003/1

4 years, 4 months ago (2016-08-17 08:48:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages