LayoutTests/fast/css/parsing-object-fit.html - Issue 22482004: Add support for the object-fit CSS property.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/parsing-object-fit.html

Issue 22482004: Add support for the object-fit CSS property. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Oops, sorry! Forgot to update UseCounter.cpp Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/object-fit-video-poster-expected.html ('k') | LayoutTests/fast/css/parsing-object-fit-expected.txt » ('j') | Source/core/platform/graphics/LayoutSize.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <link rel="stylesheet" href="../js/resources/js-test-style.css">	4 <link rel="stylesheet" href="../js/resources/js-test-style.css">

5 <script src="../js/resources/js-test-pre.js"></script>	5 <script src="../js/resources/js-test-pre.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <p id="description"></p>	8 <p id="description"></p>

9 <div id="console"></div>	9 <div id="console"></div>

10 <script src="script-tests/box-shadow-parsing-invalid.js"></script>	10 <script src="script-tests/parsing-object-fit.js"></script>
	ojan 2013/08/08 02:36:55 We're moving away from using script-tests wherever We're moving away from using script-tests wherever they're not pure JS tests (i.e. can be run solely in the JS VM). Having the actual test content be outside the test file adds extra maintenance overhead for that file. You can still use js-test-pre/js-test-post. Just inline the JS here. Also, you don't need the description/console/link elements, those get added for you. And then you can make the doctype the usual HTML5 one. mstensho (USE GERRIT) 2013/08/08 07:26:42 Done. Show quoted text On 2013/08/08 02:36:55, ojan wrote: > We're moving away from using script-tests wherever they're not pure JS tests > (i.e. can be run solely in the JS VM). Having the actual test content be outside > the test file adds extra maintenance overhead for that file. > > You can still use js-test-pre/js-test-post. Just inline the JS here. > > Also, you don't need the description/console/link elements, those get added for > you. And then you can make the doctype the usual HTML5 one. Done.
11 <script src="../js/resources/js-test-post.js"></script>	11 <script src="../js/resources/js-test-post.js"></script>

12 </body>	12 </body>

13 </html>	13 </html>

OLD	NEW