Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 22482002: Moved power_monitor_test_base to a more appropriate location (Closed)

Created:
7 years, 4 months ago by bajones
Modified:
7 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed Windows dll linkage warnings #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -123 lines) Patch
M base/base.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M base/base.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D base/power_monitor/power_monitor_test_base.h View 1 chunk +0 lines, -50 lines 0 comments Download
D base/power_monitor/power_monitor_test_base.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M base/power_monitor/power_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/test/power_monitor_test_base.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
A + base/test/power_monitor_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/power_monitor_message_broadcaster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/power_monitor_broadcast_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
bajones
@brettw: Is this what you had in mind?
7 years, 4 months ago (2013-08-06 20:48:09 UTC) #1
brettw
LGTM, thanks!
7 years, 4 months ago (2013-08-06 21:00:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/22482002/1
7 years, 4 months ago (2013-08-06 21:03:01 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-06 22:10:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/22482002/21001
7 years, 4 months ago (2013-08-08 19:48:01 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-08 20:33:36 UTC) #6
bajones
Committed patchset #2 manually as r216592 (presubmit successful).
7 years, 4 months ago (2013-08-09 05:02:16 UTC) #7
bajones
7 years, 4 months ago (2013-08-09 17:45:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r216716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698