Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2248183002: VR Shell Experimental work master (Closed)

Created:
4 years, 4 months ago by mthiesse1
Modified:
4 years, 2 months ago
Reviewers:
bajones, bshe
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, cc-bugs_chromium.org, James Su, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VR Shell Experimental work master See go/riding-hoverboard for setup instructions. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Merge in strictmode fixes #

Patch Set 3 : Fix click targeting #

Patch Set 4 : Reset device pixel ratio when exiting VR #

Patch Set 5 : Sync with ToT, and merge in Brandon's 2219203002 #

Patch Set 6 : Remove prohibited dependencies on content/browser #

Patch Set 7 : klausw@ Fixes for multi-panel UI. #

Patch Set 8 : Implement removing UI elements #

Patch Set 9 : Implement animations + control from javascript! #

Patch Set 10 : Add missing files #

Patch Set 11 : Implement remote UI contents (behind define) #

Patch Set 12 : rebase onto ToT #

Patch Set 13 : Fix build issues #

Patch Set 14 : Fix corrupt resources #

Patch Set 15 : cjgrant@ Wire input click events through UI element rectangles. #

Patch Set 16 : Fix toolbar height #

Patch Set 17 : Implement transparent UI contents -- must re-enter VR currently #

Patch Set 18 : Klausw@: VrShell: remove obsolete icon planes, tweak intersection code #

Patch Set 19 : cjgrant@: Pass pointer move events to UI control elements. #

Patch Set 20 : Default to using localhost:8080 for UI, falling back on alternate. #

Patch Set 21 : Rebase onto 2252103002 + Remove orientation hooks + Fixes for different resolutions #

Patch Set 22 : Rebase onto ToT #

Patch Set 23 : Lots of cleanup - fixes presubmit errors. #

Patch Set 24 : bsheedy@ Added StrictMode violation fix #

Patch Set 25 : More style guide refactorings #

Patch Set 26 : Ugly hacks to get transparency working. #

Patch Set 27 : Fix segfault and rebase onto ToT #

Patch Set 28 : Enter VR from Menu, Back button to exit VR #

Patch Set 29 : Fix compile without VR Shell, and handle Daydream intent. #

Patch Set 30 : Fix frozen content window when re-entering VR. #

Patch Set 31 : cjgrant@ Hook up UI control functionality. #

Patch Set 32 : cjgrant@ VR Shell JS UI: Reinstate rotation, improve animation. #

Patch Set 33 : Fix physical backing size being set incorrectly. #

Patch Set 34 : cjgrant@ Use Josh's github repo as the fallback UI asset source. #

Patch Set 35 : Klaus' rebase + Fix controller crash + Fix illegal includes #

Patch Set 36 : rebase #

Patch Set 37 : Fix crash loading remote contents. #

Patch Set 38 : Rebase onto landed patch + Implement Actions natively #

Patch Set 39 : Fix 'bonus' RWHVA being created and wrecking havoc. #

Patch Set 40 : asimjour@ new gesture detection #

Patch Set 41 : cjgrant@ Add VR Shell animation classes and unit test #

Patch Set 42 : cjgrant@ Add initial scene graph support #

Patch Set 43 : cjgrant@ Ignore input on invisible UI rectangles #

Patch Set 44 : Implement daydream reticle + laser (approximately). #

Patch Set 45 : Rebase onto ToT #

Patch Set 46 : Fix gaze cursor. Handle moves during scroll/click events. #

Patch Set 47 : Clean up/Delete now unnecessary code #

Patch Set 48 : Rebase on top of compositor refactor. #

Patch Set 49 : Rebase onto landed patches #

Patch Set 50 : Remove unnecessary changes. #

Patch Set 51 : Overwrite Biao's resource changes (sorry Biao) #

Patch Set 52 : Fix Cursor targeting to smooth transition between z-indices #

Patch Set 53 : Scale reticle based on distance. #

Patch Set 54 : Rebase onto landed patches + cjgrant@: Scene and JS fixes #

Patch Set 55 : Rebase onto landed patches #

Patch Set 56 : rebase onto ToT #

Patch Set 57 : Remove no longer necessary changes. #

Patch Set 58 : Re-implement control container hiding, but properly this time. #

Patch Set 59 : Rebase onto landed patches #

Patch Set 60 : Rebase + refactor controller patch #

Patch Set 61 : Rebase + fix fullscreen #

Patch Set 62 : Rebase #

Patch Set 63 : Remove DPR overrides #

Patch Set 64 : Rebase onto landed patches #

Patch Set 65 : Rebase #

Patch Set 66 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 6 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
bshe
On 2016/08/22 15:49:02, mthiesse1 wrote: > Patchset #11 (id:190001) has been deleted +myself as reviewer ...
4 years, 4 months ago (2016-08-24 14:09:13 UTC) #5
bajones
4 years, 3 months ago (2016-09-14 03:14:29 UTC) #10 
On 2016/08/24 14:09:13, bshe wrote:
> +myself as reviewer so it is easier for me to find

+myself as a reviewer as well, for the same reasons.

Powered by Google App Engine
This is Rietveld 408576698