Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2248163003: Include //url/mojo generated Mojo bindings in the archive. (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Include //url/mojo generated Mojo bindings in the archive. This was the cause of the build breakage that led to reverting r412305. BUG=None Committed: https://chromium.googlesource.com/chromium/tools/build/+/8598c1dbdbc1c7cbb3936850256d419e9c04b942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M scripts/slave/zip_build.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 4 months ago (2016-08-16 21:49:08 UTC) #2
Vadim Sh.
lgtm
4 years, 4 months ago (2016-08-16 21:53:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248163003/1
4 years, 4 months ago (2016-08-16 21:55:20 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 21:59:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/8598c1dbdbc1c7cbb393...

Powered by Google App Engine
This is Rietveld 408576698