chrome/browser/themes/theme_service.cc - Issue 2248103002: Reland: Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_service.cc

Issue 2248103002: Reland: Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Properly handle incognito browsing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/themes/theme_properties.cc ('K') | « chrome/browser/themes/theme_properties.cc ('k') | chrome/browser/ui/chrome_style.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/theme_service.cc

diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc

index 3abfc223684dc59dcf036bcd0ad86b9abf321dca..5ffd491ef71df1b19acd462a0b2997d8a1dfe29a 100644

--- a/chrome/browser/themes/theme_service.cc

+++ b/chrome/browser/themes/theme_service.cc

@@ -468,10 +468,6 @@ SkColor ThemeService::GetDefaultColor(int id, bool incognito) const {

if (UsingDefaultTheme())

break;

return GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT, incognito);

- case ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND:

- if (UsingDefaultTheme())

- break;

- return GetColor(ThemeProperties::COLOR_TOOLBAR, incognito);

case ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR:

if (UsingDefaultTheme())

break;