chrome/browser/media/webrtc_browsertest.cc - Issue 2248093002: Reland of "Adds a WebRTC browser_test with opus dtx enabled.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_browsertest.cc

Issue 2248093002: Reland of "Adds a WebRTC browser_test with opus dtx enabled.". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for crash. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc ('k') | chrome/browser/media/webrtc_browsertest_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc_browsertest.cc

diff --git a/chrome/browser/media/webrtc_browsertest.cc b/chrome/browser/media/webrtc_browsertest.cc

index 2f5d35f1bfa6ac4b15d9619ee5b3c25248ec9473..34da7bd29ab9ee73acad50bbe2fccac941f3b327 100644

--- a/chrome/browser/media/webrtc_browsertest.cc

+++ b/chrome/browser/media/webrtc_browsertest.cc

@@ -62,7 +62,11 @@ class WebRtcBrowserTest : public WebRtcTestBase {

SetupPeerconnectionWithLocalStream(left_tab_, offer_cert_keygen_alg);

SetupPeerconnectionWithLocalStream(right_tab_, answer_cert_keygen_alg);

- NegotiateCall(left_tab_, right_tab_, video_codec);

+ if (!video_codec.empty()) {

+ SetDefaultVideoCodec(left_tab_, video_codec);

+ SetDefaultVideoCodec(right_tab_, video_codec);

+ }

+ NegotiateCall(left_tab_, right_tab_);

DetectVideoAndHangUp();

}

@@ -84,7 +88,7 @@ class WebRtcBrowserTest : public WebRtcTestBase {

left_tab_, "gCertificateClone");

SetupPeerconnectionWithLocalStream(right_tab_, cert_keygen_alg);

- NegotiateCall(left_tab_, right_tab_, WebRtcTestBase::kUseDefaultVideoCodec);

+ NegotiateCall(left_tab_, right_tab_);

DetectVideoAndHangUp();

}