Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2248093002: Reland of "Adds a WebRTC browser_test with opus dtx enabled.". (Closed)

Created:
4 years, 4 months ago by Ivo-OOO until feb 6
Modified:
4 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, posciak+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, tnakamura+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Adds a WebRTC browser_test with opus dtx enabled.". Original CL: https://codereview.chromium.org/2190533002/ Original commit: e9df939bf67e2dea8e3ca1d9a0857272324611b8 Revert CL: https://codereview.chromium.org/2195293002/ Revert commit: 0dc179b22f88b81c6a083670bb09f22108420a4e The crash in the WebRTC audio quality browser tests was caused by one misplaced line in the javascript code. BUG=631927 TBR=phoglund@chromium.org,jochen@chromium.org,minyue@chromium.org

Patch Set 1 : Original CL #

Patch Set 2 : Fix for crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -68 lines) Patch
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.h View 2 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 5 chunks +23 lines, -28 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_perf.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_perf_browsertest.cc View 6 chunks +38 lines, -8 lines 0 comments Download
M chrome/browser/media/webrtc_video_quality_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/webrtc/munge_sdp.js View 2 chunks +44 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection.js View 1 5 chunks +55 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248093002/20001
4 years, 4 months ago (2016-08-17 11:16:55 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-17 11:16:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248093002/20001
4 years, 4 months ago (2016-08-17 15:30:24 UTC) #14
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-17 15:30:26 UTC) #16
minyue
On 2016/08/17 15:30:26, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 3 months ago (2016-09-20 07:27:29 UTC) #17
Henrik Grunell
On 2016/09/20 07:27:29, minyue wrote: > On 2016/08/17 15:30:26, commit-bot: I haz the power wrote: ...
4 years, 3 months ago (2016-09-20 07:35:40 UTC) #18
Henrik Grunell
On 2016/09/20 07:35:40, Henrik Grunell wrote: > On 2016/09/20 07:27:29, minyue wrote: > > On ...
4 years, 3 months ago (2016-09-20 07:36:29 UTC) #19
Henrik Grunell
On 2016/09/20 07:36:29, Henrik Grunell wrote: > On 2016/09/20 07:35:40, Henrik Grunell wrote: > > ...
4 years, 3 months ago (2016-09-20 07:38:06 UTC) #20
minyue
4 years, 3 months ago (2016-09-20 07:52:18 UTC) #21
On 2016/09/20 07:38:06, Henrik Grunell wrote:
> On 2016/09/20 07:36:29, Henrik Grunell wrote:
> > On 2016/09/20 07:35:40, Henrik Grunell wrote:
> > > On 2016/09/20 07:27:29, minyue wrote:
> > > > On 2016/08/17 15:30:26, commit-bot: I haz the power wrote:
> > > > > No L-G-T-M from a valid reviewer yet. 
> > > > > CQ run can only be started by full committers or once the patch has
> > > > > received an L-G-T-M from a full committer.
> > > > > Even if an L-G-T-M may have been provided, it was from a
non-committer,
> > > > > _not_ a full super star committer.
> > > > > See http://www.chromium.org/getting-involved/become-a-committer
> > > > > Note that this has nothing to do with OWNERS files.
> > > > 
> > > > Did this get landed?
> > > 
> > > It was rolled by hbos@ in https://codereview.chromium.org/2352673002.
> > 
> > Oops, sorry. Wrong CL. Please ignore. :)
> 
> However, I did land it here: https://codereview.chromium.org/2254133002/

ok. thanks. We can then delete this CL, right?

Powered by Google App Engine
This is Rietveld 408576698