chrome/browser/resources/settings/settings_page/settings_subpage.js - Issue 2248083004: Settings: Fix Clear Browsing Data dialog scrolling to Privacy page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.js

Issue 2248083004: Settings: Fix Clear Browsing Data dialog scrolling to Privacy page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/route.js ('K') | « chrome/browser/resources/settings/route.js ('k') | chrome/test/data/webui/settings/route_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_subpage.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage.js b/chrome/browser/resources/settings/settings_page/settings_subpage.js

index e7b171a1cc96cfe37bdb379e6adc9fae39057587..c151def875a6c26bb04fc3f4d2be87aa77a17a3a 100644

--- a/chrome/browser/resources/settings/settings_page/settings_subpage.js

+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.js

@@ -43,15 +43,7 @@ Polymer({

/** @private */

onTapBack_: function() {

- var previousRoute =

- window.history.state &&

- assert(settings.getRouteForPath(

- /** @type {string} */ (window.history.state)));

- if (previousRoute && previousRoute.contains(settings.getCurrentRoute()))

- window.history.back();

- else

- settings.navigateTo(assert(settings.getCurrentRoute().parent));

+ settings.navigateToPreviousRoute();

/** @private */

« chrome/browser/resources/settings/route.js ('K') | « chrome/browser/resources/settings/route.js ('k') | chrome/test/data/webui/settings/route_tests.js » ('j') | no next file with comments »