Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4615)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2248083004: Settings: Fix Clear Browsing Data dialog scrolling to Privacy page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index 496fd34ba9b6af51736cfb91503dd744354ed4d9..49d4acbcb6066d719d45a1625828ca1e5473e238 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -82,7 +82,9 @@ Polymer({
/** @private */
onDialogClosed_: function() {
- settings.navigateTo(settings.Route.PRIVACY);
+ // Opening the dialog performs a navigation, but not necessarily from
+ // PRIVACY section. Browser Back restores the old route without scrolling.
+ window.history.back();
michaelpg 2016/08/16 23:28:02 Seems like a behavior the router should be respons
tommycli 2016/08/16 23:50:08 Done. Yes you are absolutely correct here. I real
},
<if expr="_google_chrome and not chromeos">
« no previous file with comments | « no previous file | chrome/browser/resources/settings/route.js » ('j') | chrome/browser/resources/settings/route.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698