Settings: Fix Clear Browsing Data dialog scrolling to Privacy page

chrome/browser/resources/settings/privacy_page/privacy_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-privacy-page' is the settings page containing privacy and
  * security settings.
  */
 Polymer({
@@ skipping 64 matching lines @@
     settings.navigateTo(settings.Route.SITE_SETTINGS);
   },
 
   /** @private */
   onClearBrowsingDataTap_: function() {
     settings.navigateTo(settings.Route.CLEAR_BROWSER_DATA);
   },
 
   /** @private */
   onDialogClosed_: function() {
-    settings.navigateTo(settings.Route.PRIVACY);
+    // Opening the dialog performs a navigation, but not necessarily from
+    // PRIVACY section. Browser Back restores the old route without scrolling.
+    window.history.back();

[michaelpg, 2016/08/16 23:28:02]

Seems like a behavior the router should be responsible for. e.g., navigate to
"the previous route", whatever it was, with a fallback of Basic.

Since this is a navigable route... history.back() could go back to before
Settings.

[tommycli, 2016/08/16 23:50:08]

Done.

Yes you are absolutely correct here. I realized the desired behavior is the same
as settings-subpage.

If there is no previous route, it goes to Advanced.

   },
 
 <if expr="_google_chrome and not chromeos">
   /** @private */
   onMetricsReportingCheckboxTap_: function() {
     var browserProxy = settings.PrivacyPageBrowserProxyImpl.getInstance();
     var enabled = this.$.metricsReportingCheckbox.checked;
     browserProxy.setMetricsReportingEnabled(enabled);
   },
 
   /**
    * @param {!MetricsReporting} metricsReporting
    * @private
    */
   setMetricsReporting_: function(metricsReporting) {
     this.metricsReporting_ = metricsReporting;
   },
 </if>
 });