Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2248083002: [Feature Policy] Add command-line flag and about://flags interface for Feature Policy (Closed)

Created:
4 years, 4 months ago by iclelland
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman, pfeldman
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Feature Policy] Add command-line flag and about://flags interface for Feature Policy BUG=638238 Committed: https://crrev.com/6dd7342f95b5de8a5a273c31fee7452532c19030 Cr-Commit-Position: refs/heads/master@{#412534}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
iclelland
+r isherman for histograms +r pfeldman for everything else :) Can you guys PTAL? Thanks!
4 years, 4 months ago (2016-08-16 15:16:10 UTC) #5
pfeldman
lgtm
4 years, 4 months ago (2016-08-16 16:24:23 UTC) #8
Ilya Sherman
histograms.xml lgtm
4 years, 4 months ago (2016-08-16 20:44:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248083002/1
4 years, 4 months ago (2016-08-17 13:10:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/239806)
4 years, 4 months ago (2016-08-17 13:15:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248083002/20001
4 years, 4 months ago (2016-08-17 13:39:15 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 15:25:26 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 15:27:15 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dd7342f95b5de8a5a273c31fee7452532c19030
Cr-Commit-Position: refs/heads/master@{#412534}

Powered by Google App Engine
This is Rietveld 408576698