Issue 2248063002: Revert of [api] Templatize do_callback parameter in CallDepthScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2248063002: Revert of [api] Templatize do_callback parameter in CallDepthScope (Closed)

Created:
4 years, 4 months ago by Camillo Bruni

Modified:
4 years, 3 months ago

Reviewers:
Franzi

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [api] Templatize do_callback parameter in CallDepthScope (patchset #3 id:40001 of https://codereview.chromium.org/2220993003/ ) Reason for revert: breaks checks Original issue's description: > [api] Templatize do_callback parameter in CallDepthScope > > Drive-by-fix: mark isolates as const in stack-allocated scopes > > BUG=chromium:630217 > > Committed: https://crrev.com/0cabbd3d60acf1e040113d59e4cdbc99b953843b > Cr-Commit-Position: refs/heads/master@{#38496} TBR=franzih@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:630217

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -14 lines)			Patch
M	include/v8.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View	4 chunks	+17 lines, -10 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

Camillo Bruni

4 years, 4 months ago (2016-08-16 13:38:49 UTC) #1

Created Revert of [api] Templatize do_callback parameter in CallDepthScope