Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2248013004: [Android] Introduce LocaleManager to Chrome (Closed)

Created:
4 years, 4 months ago by Ian Wen
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Introduce LocaleManager to Chrome LocaleManager will manage the locale specific logic in Chrome. Currently the only thing it does is to record some metrics in deferred startup. BUG=630703 Committed: https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003 Cr-Commit-Position: refs/heads/master@{#412709}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, --1 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 4 chunks +4 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/locale/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ian Wen
isherman@ FYI
4 years, 4 months ago (2016-08-16 23:27:03 UTC) #2
gone
lgtm https://chromiumcodereview.appspot.com/2248013004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java File chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java (right): https://chromiumcodereview.appspot.com/2248013004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java#newcode17 chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:17: mAppContext = appContext; Can't the internal one just ...
4 years, 4 months ago (2016-08-17 16:39:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248013004/20001
4 years, 4 months ago (2016-08-17 22:34:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 00:49:49 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 00:55:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003
Cr-Commit-Position: refs/heads/master@{#412709}

Powered by Google App Engine
This is Rietveld 408576698