Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2248013003: PlzNavigate: Fix crash when loading unreachable URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index cb9e3d3faa5df2dc38de129057f07c3d243797bb..c80a791e32d1baff32eafb894fa4bb235b206db3 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4878,9 +4878,8 @@ void RenderFrameImpl::OnFailedNavigation(
frame_->isViewSourceModeEnabled());
SendFailedProvisionalLoad(failed_request, error, frame_);
- // This check should have been done on the browser side already.
if (!ShouldDisplayErrorPageForFailedLoad(error_code, common_params.url)) {
- NOTREACHED();
+ didStopLoading();
clamy 2016/08/17 13:17:06 We should send the IPC directly, as this is more o
arthursonzogni 2016/08/17 13:45:09 Done.
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698