Chromium Code Reviews| Index: chrome/test/mini_installer/verifier.py |
| diff --git a/chrome/test/mini_installer/verifier.py b/chrome/test/mini_installer/verifier.py |
| index 7b0fae6c46e0dc6dc16d204d4902e3edaa1cf2bd..831fc7af81b0157d4d88cb876fa5c0a402e364b6 100644 |
| --- a/chrome/test/mini_installer/verifier.py |
| +++ b/chrome/test/mini_installer/verifier.py |
| @@ -4,12 +4,16 @@ |
| import registry_verifier |
| + |
| def Verify(property): |
| - """Verifies that the current machine states match the property object.""" |
| + """Verifies that the current machine states match the property dictionary. |
| + |
| + Args: |
| + property: A property dictionary. |
|
Mathieu
2013/08/12 17:37:26
can you describe what is a value in this dictionar
sukolsak
2013/08/12 19:20:20
Done.
|
| + """ |
| for verifier_name, value in property.iteritems(): |
|
Mathieu
2013/08/12 17:37:26
perhaps rename value -> entries to be more consist
sukolsak
2013/08/12 19:20:20
Other verifiers that I am going to add will have d
|
| if verifier_name == 'RegistryEntries': |
| registry_verifier.VerifyRegistryEntries(value) |
| else: |
| # TODO(sukolsak): Implement other verifiers |
| - # TODO(sukolsak): Use unittest framework instead of exceptions. |
| - raise Exception('Unknown verifier') |
| + raise KeyError('Unknown verifier %s' % verifier_name) |