Add support for a whitelist of supported platforms for a CIPD package.

Add support for a whitelist of supported platforms for a CIPD package.

Also create an android-only package for the device watchdog.

BUG=632895
Committed: https://chromium.googlesource.com/infra/infra/+/ceb9067257a11233b4b8f83e781281ac58773de2

[bpastene, 2016-08-16 01:27:53]

bpastene@chromium.org changed reviewers:
+ vadimsh@chromium.org

[bpastene, 2016-08-16 01:27:54]

ptal/let me know what you think!

[Vadim Sh., 2016-08-16 01:39:35]

lgtm with nits

https://codereview.chromium.org/2247983002/diff/20001/build/build.py
File build/build.py (right):

https://codereview.chromium.org/2247983002/diff/20001/build/build.py#newcode91
build/build.py:91: return any(p in target_platform for p in supported_platforms)
nit: return target_platform in supported_platforms

https://codereview.chromium.org/2247983002/diff/20001/build/build.py#newcode106
build/build.py:106: if 'android' in os.environ.get('GOOS', ''):
nit: if os.environ.get('GOOS', '') == 'android'

https://codereview.chromium.org/2247983002/diff/20001/build/packages/device_w...
File build/packages/device_watchdog.yaml (right):

https://codereview.chromium.org/2247983002/diff/20001/build/packages/device_w...
build/packages/device_watchdog.yaml:4: - infra-continuous-precise-64
I'm concerned it would make our CI cycles time skyrocket

If it does indeed adds more than 5 min to the cycle, we'd probably need to setup
a manually triggered builder for this (so if new release of device_watchdog is
needed, one goes to the Buildbot and clicks "Build now" button).

https://codereview.chromium.org/2247983002/diff/20001/build/packages/device_w...
build/packages/device_watchdog.yaml:12: - file: device_watchdog${exe_suffix}
${exe_suffix} would always be empty string here (since Windows is not one of the
supported_platforms), no need to specify it

[bpastene, 2016-08-16 19:05:29]

https://codereview.chromium.org/2247983002/diff/20001/build/build.py
File build/build.py (right):

https://codereview.chromium.org/2247983002/diff/20001/build/build.py#newcode91
build/build.py:91: return any(p in target_platform for p in supported_platforms)
On 2016/08/16 01:39:35, Vadim Sh. wrote:
> nit: return target_platform in supported_platforms

Done.

https://codereview.chromium.org/2247983002/diff/20001/build/build.py#newcode106
build/build.py:106: if 'android' in os.environ.get('GOOS', ''):
On 2016/08/16 01:39:35, Vadim Sh. wrote:
> nit: if os.environ.get('GOOS', '') == 'android'

Done.

https://codereview.chromium.org/2247983002/diff/20001/build/packages/device_w...
File build/packages/device_watchdog.yaml (right):

https://codereview.chromium.org/2247983002/diff/20001/build/packages/device_w...
build/packages/device_watchdog.yaml:4: - infra-continuous-precise-64
On 2016/08/16 01:39:35, Vadim Sh. wrote:
> I'm concerned it would make our CI cycles time skyrocket
> 
> If it does indeed adds more than 5 min to the cycle, we'd probably need to
setup
> a manually triggered builder for this (so if new release of device_watchdog is
> needed, one goes to the Buildbot and clicks "Build now" button).

Understood; and agreed. But I don't think it should add more than 60s when all
is said and done. Let me try adding it to the builder. If it does indeed inflate
the cycle time significantly, I'll split it off.

https://codereview.chromium.org/2247983002/diff/20001/build/packages/device_w...
build/packages/device_watchdog.yaml:12: - file: device_watchdog${exe_suffix}
On 2016/08/16 01:39:35, Vadim Sh. wrote:
> ${exe_suffix} would always be empty string here (since Windows is not one of
the
> supported_platforms), no need to specify it

Done.

[bpastene, 2016-08-16 19:42:56]

The CQ bit was checked by bpastene@chromium.org

[bpastene, 2016-08-16 19:42:57]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2247983002/#ps40001
(title: "Comments + mobile_env.py cwd fix.")

[commit-bot: I haz the power, 2016-08-16 19:43:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 19:58:23]

Description was changed from

==========
Add support for a whitelist of supported platforms for a CIPD package.

Also create an android-only package for the device watchdog.

BUG=632895
==========

to

==========
Add support for a whitelist of supported platforms for a CIPD package.

Also create an android-only package for the device watchdog.

BUG=632895

Committed:
https://chromium.googlesource.com/infra/infra/+/ceb9067257a11233b4b8f83e78128...
==========

[commit-bot: I haz the power, 2016-08-16 19:58:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/ceb9067257a11233b4b8f83e78128...