[ios] Use new JS execution API for Autofill.

[ios] Use new JS execution API for Autofill.

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=595761
Committed: https://crrev.com/4f14e1745e8329b84197654fe6c47d92165a9ee8
Cr-Commit-Position: refs/heads/master@{#412548}

[Eugene But (OOO till 7-30), 2016-08-16 00:45:56]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 00:46:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 01:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 01:37:48]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-08-16 01:41:11]

eugenebut@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Justin Donnelly, 2016-08-17 14:29:18]

lgtm with question

https://codereview.chromium.org/2247973002/diff/1/components/autofill/ios/bro...
File components/autofill/ios/browser/js_suggestion_manager.mm (right):

https://codereview.chromium.org/2247973002/diff/1/components/autofill/ios/bro...
components/autofill/ios/browser/js_suggestion_manager.mm:83: NSArray* components
= [result componentsSeparatedByString:@","];
Dumb Obj-C question: you don't need to cast result to NSString before calling
componentsSeparatedByString: on it?

[Eugene But (OOO till 7-30), 2016-08-17 15:33:27]

Thanks!

https://codereview.chromium.org/2247973002/diff/1/components/autofill/ios/bro...
File components/autofill/ios/browser/js_suggestion_manager.mm (right):

https://codereview.chromium.org/2247973002/diff/1/components/autofill/ios/bro...
components/autofill/ios/browser/js_suggestion_manager.mm:83: NSArray* components
= [result componentsSeparatedByString:@","];
On 2016/08/17 14:29:18, Justin Donnelly wrote:
> Dumb Obj-C question: you don't need to cast result to NSString before calling
> componentsSeparatedByString: on it?
I think this code is fine as it is. .toString() should either return string or
throw exception. If former then |result| is already a string. If latter then
|result| will be nil and this code will fail gracefully as well.

[Eugene But (OOO till 7-30), 2016-08-17 15:33:30]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:33:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:14:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 16:16:39]

Description was changed from

==========
[ios] Use new JS execution API for Autofill.

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=595761
==========

to

==========
[ios] Use new JS execution API for Autofill.

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=595761

Committed: https://crrev.com/4f14e1745e8329b84197654fe6c47d92165a9ee8
Cr-Commit-Position: refs/heads/master@{#412548}
==========

[commit-bot: I haz the power, 2016-08-17 16:16:40]

Patchset 1 (id:??) landed as
https://crrev.com/4f14e1745e8329b84197654fe6c47d92165a9ee8
Cr-Commit-Position: refs/heads/master@{#412548}