Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2247953004: Removed private web_main_runner.h header. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed private web_main_runner.h header. There is public web_main_runner.h header in ios/web. BUG=616247 Committed: https://crrev.com/59015d95fdf912750e80b5c8ae7bb9ae8543a3a7 Cr-Commit-Position: refs/heads/master@{#412321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M ios/web/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ios/web/app/web_main_runner.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-16 18:46:04 UTC) #6
Jackie Quinn
lgtm
4 years, 4 months ago (2016-08-16 19:37:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247953004/1
4 years, 4 months ago (2016-08-16 19:49:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 20:18:40 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 20:26:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59015d95fdf912750e80b5c8ae7bb9ae8543a3a7
Cr-Commit-Position: refs/heads/master@{#412321}

Powered by Google App Engine
This is Rietveld 408576698