Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2247933003: Instrument flaky tests in CronetUrlRequestContextTest (Closed)

Created:
4 years, 4 months ago by kapishnikov
Modified:
4 years, 4 months ago
Reviewers:
mgersh, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrument flaky tests in CronetUrlRequestContextTest BUG=635025, 596929 Committed: https://crrev.com/1c83f45c207fbcba48a65a7c87a7eea741f100a4 Cr-Commit-Position: refs/heads/master@{#412273}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Removed "cr_" prefix from the TAG. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 2 7 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kapishnikov
4 years, 4 months ago (2016-08-16 15:47:56 UTC) #2
xunjieli
lgtm. Thanks Andrei! https://codereview.chromium.org/2247933003/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java File components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java (right): https://codereview.chromium.org/2247933003/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java#newcode45 components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java:45: private static final String TAG = ...
4 years, 4 months ago (2016-08-16 16:28:46 UTC) #3
mgersh
lgtm
4 years, 4 months ago (2016-08-16 16:34:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247933003/40001
4 years, 4 months ago (2016-08-16 16:50:57 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-16 17:25:35 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 17:27:49 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1c83f45c207fbcba48a65a7c87a7eea741f100a4
Cr-Commit-Position: refs/heads/master@{#412273}

Powered by Google App Engine
This is Rietveld 408576698